-
Notifications
You must be signed in to change notification settings - Fork 199
New: Enhance API endpoint to support additional filters #7285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Enhance API endpoint to support additional filters #7285
Conversation
|
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
3579553 to
b4f5184
Compare
use parentheses on OR WHERE clause
b6d9e43 to
eeac823
Compare
|
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
|
This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed. |
|
Hey @pulsovi 👋 This is a really cool idea! Unfortunately its been a couple years and the PR review was never prioritized by our team - so its gotten out of sync with the main branch. We've also made some updates to the endpoint and UI over time. I think at this point it will be better to close this and use as inspiration for a new PR that is more in sync with our current branch. Since we're such a small team, I would also suggest keeping the PR as small as possible or else it can be overwhelming to review as we have lots of internal priorities to manage. We really appreciate your contributions and hope we can collaborate on some new solutions 🙂 |
New: Enhance API endpoint to support additional filters
Resolves #7484
Description
Enhances the
Give\Donations\Endpoints\ListDonationsAPI endpoint to support additional filters, providing the necessary hooks for compatibility with third party add-ons / snippets.The main goal is to extend the flexibility of the Donations\ListTable in the admin interface, allowing for the integration of new filters, such as filtering donations by donor ID.
Affects
Admin List Tables
Visuals
N/A
Testing Instructions
Tests already included in PR : see
tests/Unit/Donations/Endpoints/TestListDonations:testShouldAllowAddingFiltersTo test the new hooks and extension points, add some JavaScript code on the front-end page (via a snippet):
Go to the
back office > Give > Donations, new filter input added for Donor ID, lastname or firstname.To allow using filters that are not already managed by ListDonations
Pre-review Checklist
[-] Reviewed by the designer (if follows a design)